-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Video controls which don't obscure the video when paused #6050
Comments
The proposed solution is not feasible as it would require creating a completely custom UI (may I remind you that we are volunteers with limited time and we do not have enough time to go wasting it on that) and also would result in the controls not appearing inside fullscreen mode, because they would be outside of the player. You are also using FreeTube maximised, but you have to keep in mind that not everyone does and FreeTube supports all sorts of window sizes, even mobile devices, so that extra space you are talking about is not there is most situations. There are actually even open issues about moving things like the format switching into the player, because their current position requires some people to scroll while watching the video, you would be asking for the opposite which would make that situation significantly worse. The whole point of the controls showing up when you pause the video is so that you can use them, sure you personally might not use FreeTube like that but making the controls much harder to access is a no-go. There are also people that use FreeTube with just a keyboard, screen readers or touchscreens so you cannot rely just on the mouse hovering over the video. If you have any suggestions that don't require a massive amount of work or make the app unnecessarily harder to use, you are welcome to suggest them, but your current ones are not feasible. |
The proposed solution is just one idea, added there because the issue template steers you into writing it. The main deal of the feature request (at least in this case, in my opinion) is the problem description. I proposed that solution because, while I'm well aware that it might be the least likely to ever happen, it is also the one that seemed the most feature complete. Perhaps too much, though. I'm not aware of the implementation details of the application and the video player library that it uses, but I considered that, perhaps, there is a slight chance that the controls can be implemented in the library in such a way that they could be rendered as a control that can be positioned elsewhere (perhaps not right now, but in the future, if someone would want to add the feature). That would require not that much work to position the controls on top of the video frame, or adjacent to it. But it's just an idea. Let me also stress out that I've not suggested just one idea, as the issue template again steers you to propose more things, and I've proposed two. The controls fading away on pause is what Freetube already does when the video is playing, and what most video players do, so it seemed a good usability improvement that I assumed it would not be too time consuming to implement. I don't understand the remark of "There are also people that use FreeTube with just a keyboard, screen readers or touchscreens so you cannot rely just on the mouse hovering over the video." I already mentioned using the keyboard to pause/unpause as a case where the controls could just not fade in, which would solve the issue. If the user has used the keyboard or other input method other than mouse/touch, there would be no need to show them, I think. Showing the controls on mouse hover is already what it happening right now when the video is playing. It's just not doing that when the video is pausing (and that's basically my feature request in a nutshell). For touch devices: as I said, most video players that I've tested this days (all except one) fade out the controls away when paused. They fade in when tapped the screen. So I see no issue. Anyway, thanks for your time, and apologies if something was not clear (I'm not a native speaker after all), or I've used the feature request differently to what it was expected. Cheers. |
What about a shortcut that hides video player controls when needed? |
Guidelines
Problem Description
There are a few occasions where pausing the video is the only way to see something relevant about the it:
The playback controls (play/pause, progress, volume, etc.) are covering the bottom of the video frame. They go away when playing, but not when the video is paused.
Additionally, if what you need to watch needs pausing/unpausing (e.g. looking for artifacts, anything in motion, etc.), repeatedly pausing and unpausing the video will keep the controls fading in and fading out, but always partially shown and always obstructing the bottom of the video. The new player might have made this a bit worse by having it extra space at the bottom (see #5955).
Proposed Solution
Allow the option to place controls entirely outside the video frame, like other video players do, for example, VLC.
I suppose it would mean implementing at least part of the controls outside the video player, then toggle them off entirely, perhaps as an option if not all the controls are fully reimplemented in the new way. There should be space in the UI for this, as there already unused black margins around the video frame:
Alternatives Considered
There are a few alternatives that would probably require less work, but would be less ideal:
Issue Labels
visual improvement
Additional Information
No response
The text was updated successfully, but these errors were encountered: