Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: do not skip private (unavailable) videos when numbering items in a playlist #3660

Closed
3 tasks done
aleksejrs opened this issue Jun 13, 2023 · 4 comments
Closed
3 tasks done

Comments

@aleksejrs
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

When there are unavailable videos, YouTube playlists have two states (if you are logged in without age restrictions):

  1. Hide videos that are not available in your region or are private. The videos are numbered as if the hidden videos did not exist.
  2. Show everything. Every video has a proper number, which is different.

If I understand correctly, FreeTube should be showing videos that are not available in your region, but it is not showing videos that are private. Numbers are as if the private videos did not exist.

yt-dlp --playlist-items acts as if all videos were on the list, so FreeTube's numbers are not compatible with it.

Proposed Solution

Do not skip private videos when numbering list items.

Alternatives Considered

None, unless there is any use for the skipping.

Issue Labels

improvement to existing feature, support for external software

Additional Information

No response

@absidue
Copy link
Member

absidue commented Aug 7, 2023

Keep in mind that FreeTube always interacts with YouTube logged out, so you can't compare it to being logged into YouTube.

Just had a look, YouTube's numbering on the website is based on the videos visible in the current view:

  1. Normal (hide unavailable): Numbering is based on the available videos
  2. Show unavailable (activated with the 3 dots menu): Numbering is based on all videos in the playlist
  3. Videos only: Numbering based on visible videos/the videos in the response
  4. Shorts only: Numbering based on visible videos/the videos in the response

Conclusion: FreeTube's numbering is the same as YouTube's.

@aleksejrs
Copy link
Author

yt-dlp uses #2, even if it cannot download unavailable videos.
yt-dlp uses #1 if you specify --compat-options no-youtube-unavailable-videos.

Some videos that are unavailable can still be downloaded with a VPN or by logging in. "Show unavailable" is the view with the most stable numbering.

@absidue
Copy link
Member

absidue commented Aug 7, 2023

So this is actually a much bigger feature request, instead of just different numbering you want us to change the way we extract playlists, telling YouTube to return the useless hidden stuff (could only do it for the local API, as we only have that amount of control there, highly doubt Invidious would want a breaking change like this as it would mean that everyone using the Invidious API would have to adapt their stuff), which will also require a bunch of changes to the watch page, including rethinking and rewriting the way things like shuffling etc work so you don't end up on a broken watch page.

@efb4f5ff-1298-471a-8973-3d47447115dc

Closing this as it isn't worth it to change this much for content we cant even play and displaying it just for the sake of matching with the total videos in playlist number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants