Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Adding channel name or ID in Hide Videos From Channel does not hide it from Trending and Search results. #3419

Closed
5 tasks done
dbenedb opened this issue Apr 11, 2023 · 3 comments · Fixed by #3673
Closed
5 tasks done
Labels
B: feature stopped working bug Something isn't working

Comments

@dbenedb
Copy link

dbenedb commented Apr 11, 2023

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Adding channel name or ID in Hide Videos From Channel in Distraction Free Settings ins Settings does not hide it from Trending and Search results.

Expected Behavior

Channels added to Hide Videos From Channels in Distraction Free Settings should not be displayed in Search and Trending results.

Issue Labels

feature stopped working

FreeTube Version

v0.18.0, nightly 2855

Operating System Version

Debian sid, Linux 6.1.0-7-amd64

Installation Method

.AppImage

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

I noticed that in /renderer/components/distraction-settings/distraction-settings.js the order of last two settings in mapAction is flipped to:

'updateChannelsHidden',
'updateShowDistractionFreeTitles'

Shouldn't it be this?

'updateShowDistractionFreeTitles',
'updateChannelsHidden'

Nightly Build

@dbenedb dbenedb added the bug Something isn't working label Apr 11, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants