Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Browser extension dont work on macOS #3257

Open
4 of 5 tasks
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Mar 4, 2023 · 19 comments
Open
4 of 5 tasks

[Bug]: Browser extension dont work on macOS #3257

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Mar 4, 2023 · 19 comments
Labels
B: content not loading bug Something isn't working OS: macos All issues related to Macs, as we do not have one to test things

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

bug was reported in #2747

I did check:

But when I paste rewritten url in safari for example, it prompts to open in FreeTube, but the video does not start. I see just the default home page.

freetube://https://youtu.be/y9TizOUqsuc

Main takes:

This seems to be a macOS specific bug that doesn't exist in the Linux or Windows builds of FreeTube (macOS implements URL schemes differently than Windows and Linux).

[...] the relevant lines in FreeTube's code are here:
src/main/index.js#L738-L748
src/renderer/App.js#L501-L505

Pulled from IRC:

on Linux and Windows, the operating system does this when you use a URL scheme: /path/to/freetube.exe freetube://https://youtu.be/y9TizOUqsuc on macOS the operating system sends an event to the app which in electron is open-url, so some how our handling of it is not working properly

Expected Behavior

Extensions should work with FT

Issue Labels

content not loading

FreeTube Version

0.17.1

Operating System Version

macOS

Installation Method

.dmg

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added bug Something isn't working OS: macos All issues related to Macs, as we do not have one to test things labels Mar 4, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot May 30, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot May 30, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot May 30, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Closed
3 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

@absidue is this even an issue on our end? When i looked through the repo of both extensions we have listed it seems like they both dont support Safari.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B: content not loading bug Something isn't working OS: macos All issues related to Macs, as we do not have one to test things
Projects
Bug Reports
Status: To assign
Milestone
No milestone
Development

No branches or pull requests
2 participants
@absidue @efb4f5ff-1298-471a-8973-3d47447115dc