Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Favorite star should be bright yellow #2807

Closed
3 of 4 tasks
lonix1 opened this issue Nov 3, 2022 · 4 comments
Closed
3 of 4 tasks

[Bug]: Favorite star should be bright yellow #2807

lonix1 opened this issue Nov 3, 2022 · 4 comments
Labels
B: accessibility B: usability B: visual bug Something isn't working U: duplicate This issue or pull request already exists

Comments

@lonix1
Copy link

lonix1 commented Nov 3, 2022

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

Channels:

  1. open a channel
  2. each video shows a favourite/star icon in its top right corner
  3. star is light grey or light yellow

Videos:

  1. open a video
  2. it shows a favourite/star icon under the video
  3. star is light grey or light yellow

It's hard to distinguish between light grey and light yellow - I often can't tell whether the video is favourited or not.

I checked on multiple monitors, the problem is the same.

Expected Behavior

Please use a brighter / darker yellow.

Issue Labels

accessibility issue, usability issue, visual bug

FreeTube Version

v0.18.0 Beta

Operating System Version

Ubuntu 22.04.1 LTS

Installation Method

.deb

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@lonix1 lonix1 added the bug Something isn't working label Nov 3, 2022
@lonix1 lonix1 changed the title [Bug]: Favourite star should be brighter [Bug]: Favorite star should be bright yellow Nov 3, 2022
@lonix1
Copy link
Author

lonix1 commented Nov 3, 2022

Also: The tooltip shows "Save Video" whether the favorite is enabled or disabled. So it's not useful as a workaround.

Should I open a separate issue for changing that to "Save Video" and "Unsave Video"?

@efb4f5ff-1298-471a-8973-3d47447115dc

This isnt a bug. It was the same color in the previous version

v0.17.1
v0 17 1

v0.18.0
v0 18 0

The request of color change of the star is a duplicate of #1762

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Nov 3, 2022
@lonix1
Copy link
Author

lonix1 commented Nov 3, 2022

The fact that it was the same colour in the previous version (I agree), doesn't mean it's not a bug. It's barely visible.

@cocoonkid
Copy link

Yes, longtime big issue here. barely visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: accessibility B: usability B: visual bug Something isn't working U: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants