New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip connections #4

Open

AI-Guru opened this issue Nov 6, 2019 · 0 comments

AI-Guru commented Nov 6, 2019

Hello!

The more I work with your code, the more I like your approach!

Another thing. Could it be that the skip connections in the code are not properly reflected in the paper?

Here are the skip connections:
https://github.com/FrankCAN/GAPointNet/blob/master/models/network.py#L39
https://github.com/FrankCAN/GAPointNet/blob/master/models/network.py#L62

The paper mentions "skip-connection" exactly once. Would it make sense to show them in figure 3?

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment