Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% value in Outputs should not be rounded #3959

Closed
lthole opened this issue May 1, 2024 · 13 comments
Closed

% value in Outputs should not be rounded #3959

lthole opened this issue May 1, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lthole
Copy link
Collaborator

lthole commented May 1, 2024

Ethos 1.5.7

Curves should should not do any rounding to the nearest %.

I used a test Var of 20.6 to adjust a curve point. Using the curve to adjust the mid point of 1500us I get an output value of 1607us which is not correct, and the % value says 21.0%. Calculation is 20.6% of 512us = 105.472 so output should be 1500 + 105.472 = 1605us not 1607us.

Please refer to ch6 in the screenshot below:
image

@Alex00101
Copy link

I agree, please also note that curve points editor also does not allow anything but whole percents, it'd be much better if curve points could have the same precision as vars

@github-actions github-actions bot added the stale label Jul 31, 2024
@Alex00101
Copy link

May I please bump this up? Would be very useful if implemented

@lthole
Copy link
Collaborator Author

lthole commented Jul 31, 2024

As already argued:
In Outputs the min/max can be adjusted to within 0.1%. It is much more convenient to adjust the output using a curve, so in this case the curve should also be adjustable to within 0.1%. This is important on gliders with large control surfaces where you need to match for example the ailerons and flaps to align exactly.

@github-actions github-actions bot removed the stale label Aug 1, 2024
@bsongis-frsky bsongis-frsky self-assigned this Aug 20, 2024
@bsongis-frsky bsongis-frsky added this to the 1.5.14 milestone Aug 20, 2024
@bsongis-frsky bsongis-frsky added the enhancement New feature or request label Aug 20, 2024
@bsongis-frsky bsongis-frsky modified the milestones: 1.5.14, 1.5.15, 1.5.16 Aug 24, 2024
@FrSkyRC FrSkyRC deleted a comment from github-actions bot Aug 27, 2024
@bsongis-frsky
Copy link
Collaborator

I will work on this now. But I will really like if I get help for tests in the next nightlies, because this sort of change is dangerous if not done properly!

@bsongis-frsky
Copy link
Collaborator

I think that Curve offset should also have one decimal to be consistent!

@robthomson
Copy link
Collaborator

@bsongis-frsky let me know what u need tested.. I have time to play tomorrow on this

@bsongis-frsky
Copy link
Collaborator

image

image

image

@Alex00101
Copy link

Looks great and happy to test!

@bsongis-frsky
Copy link
Collaborator

Keyboard support added in Model / Curves screen. Much needed with 1 decimal!

image

@bsongis-frsky
Copy link
Collaborator

1 decimal added to curves offset

image

@spoke2570
Copy link

Has anyone tested the conversion process to make sure that the new precision is added the end of existing curve points, so point at 20% isn't converted to 2.0% when updating?

@bsongis
Copy link
Contributor

bsongis commented Sep 27, 2024

Yes I have checked that myself. But tests are never enough as we have seen so much in the past!

@spoke2570
Copy link

Thanks for your diligence!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants