-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
% value in Outputs should not be rounded #3959
Comments
I agree, please also note that curve points editor also does not allow anything but whole percents, it'd be much better if curve points could have the same precision as vars |
May I please bump this up? Would be very useful if implemented |
As already argued: |
I will work on this now. But I will really like if I get help for tests in the next nightlies, because this sort of change is dangerous if not done properly! |
I think that Curve offset should also have one decimal to be consistent! |
@bsongis-frsky let me know what u need tested.. I have time to play tomorrow on this |
Looks great and happy to test! |
Has anyone tested the conversion process to make sure that the new precision is added the end of existing curve points, so point at 20% isn't converted to 2.0% when updating? |
Yes I have checked that myself. But tests are never enough as we have seen so much in the past! |
Thanks for your diligence! |
Ethos 1.5.7
Curves should should not do any rounding to the nearest %.
I used a test Var of 20.6 to adjust a curve point. Using the curve to adjust the mid point of 1500us I get an output value of 1607us which is not correct, and the % value says 21.0%. Calculation is 20.6% of 512us = 105.472 so output should be 1500 + 105.472 = 1605us not 1607us.
Please refer to ch6 in the screenshot below:
The text was updated successfully, but these errors were encountered: