Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep listIndexes() response compatible #93

Closed
2 tasks done
apkar opened this issue Feb 22, 2019 · 1 comment
Closed
2 tasks done

Keep listIndexes() response compatible #93

apkar opened this issue Feb 22, 2019 · 1 comment
Labels
compatibility Either missing or incompatible features causing driver or tool compatibility

Comments

@apkar
Copy link
Contributor

apkar commented Feb 22, 2019 •
edited
Loading

Document Layer returns only secondary indexes in response to listIndexes(). Mongo drivers expect primary index (on _id, which is maintained anyway) also part of the response. It's an easy fix, we might as well do it just to make the drivers happy.

  • Include primary index
  • Add background rebuild info
@apkar apkar added the compatibility Either missing or incompatible features causing driver or tool compatibility label Feb 22, 2019
@apkar apkar changed the title Return primary index also with listIndexes() to be consistent Keep listIndexes() response compatible Feb 22, 2019
@dongxinEric
Copy link
Contributor

By Add background rebuild info do you mean also return whether this is a background built index or not?

@dongxinEric dongxinEric mentioned this issue Mar 2, 2019
Merged
@dongxinEric dongxinEric mentioned this issue Mar 9, 2019
Merged
@apkar apkar closed this as completed in #107 Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Either missing or incompatible features causing driver or tool compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dongxinEric @apkar