-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIDI thru 'full' applies to active channel only #13
Comments
Thanks for the report ! |
Thanks! Not sure if I'm understanding the library usage fully, if there's something else I need to do with setThruFilterMode() to get messages passed on the non-active channels let me know! |
No, you used it correctly, it was a bug indeed ! |
I tried re-adding the library with the new files from the dev branch, but now I'm getting an error " 'Full' was not declared in this scope". I get this even if I re-add the master through Arduino's automated 'add library...' tool (which, admittedly, is new to me) - are there other files I need to put in place? |
You just need to change Full into midi::Full, and that should do the trick. I guess you were using a version <4.0 before? |
Aha, yes, I have been using 3.2. I checked the bug with the latest version (4.1) to confirm that it was still present (it was) and then installed the dev branch. The dev branch does indeed seem to fix the issue! Thanks! I did have to manually replace the library files rather than using the Arduino menu. I've tested it with note and CC data, but can't check sysex at the moment. Thanks again! |
If you're running MacOS or Linux, you can use the script |
Thanks Franky! The thru function works very smoothly now - I've got my project up and running, if you'd like to check it out, at: |
MIDI Thru seems to apply to the active channel only, rather than all MIDI channels. For example:
will correctly send all MIDI messages received on channel 1 to the output, but no messages received on other channels. Calling setThruFilterMode(DifferentChannel) seems to disable MIDI thru entirely.
The text was updated successfully, but these errors were encountered: