Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA] Add new display asset endpoint #21

Closed
Luc1412 opened this issue Sep 3, 2024 · 0 comments · Fixed by #26
Closed

[BETA] Add new display asset endpoint #21

Luc1412 opened this issue Sep 3, 2024 · 0 comments · Fixed by #26
Assignees
@Luc1412
Labels
breaking change This issue requires a breaking change. feature request This is a feature request.

Comments

@Luc1412
Copy link
Member

Luc1412 commented Sep 3, 2024 •
edited
Loading

The wrapper currently doesn't support beta/newdisplayassets. Support should be added as a beta endpoint.

This may require a breaking change to prevent duplicated NewDisplayAsset objects, since there is already a ShopEntryNewDisplayAsset. We probably want to create a common NewDisplayAsset object within it's own file.
@Luc1412 Luc1412 added feature request This is a feature request. breaking change This issue requires a breaking change. labels Sep 3, 2024
@Luc1412 Luc1412 mentioned this issue Oct 9, 2024
Merged
6 tasks
@Luc1412 Luc1412 self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luc1412 Luc1412

Labels
breaking change This issue requires a breaking change. feature request This is a feature request.
Projects
None yet
Milestone
No milestone
1 participant
@Luc1412