Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps from class components #2683

Closed
23 tasks
carbonrobot opened this issue Dec 21, 2023 · 1 comment
Closed
23 tasks

Remove defaultProps from class components #2683

carbonrobot opened this issue Dec 21, 2023 · 1 comment
Assignees
@KenanYusuf
Labels
Type: TypeScript Issues related to typescript or type definitions

Comments

@carbonrobot
Copy link
Contributor

Remove deprecated defaultProps from the following components

  • VictoryZoomContainer
  • VictoryVoronoiContainer
  • VictoryVoronoi
  • VictoryTooltip
  • VictoryArea
  • VictoryAxis
  • VictoryBar
  • VictoryBoxPlot
  • VictoryBrushContainer
  • VictoryBrushLine
  • VictoryCandlestick
  • VictoryAccessibleGroups
  • VictoryAnimation
  • VictoryClipContainer
  • VictoryContainer
  • VictoryPortal
  • VictoryCursorContainer
  • VictoryErrorBar
  • VictoryHistogram
  • VictoryLegend
  • VictoryLine
  • VictoryScatter
  • VictoryPolarAxis
@carbonrobot carbonrobot added the Type: TypeScript Issues related to typescript or type definitions label Jan 3, 2024
@KenanYusuf KenanYusuf assigned KenanYusuf and unassigned KenanYusuf Jan 3, 2024
@KenanYusuf
Copy link
Contributor

I think we are safe to keep using defaultProps in class components, I have only seen references to them being deprecated for function components:

Tested the original Victory issue #2656 with the latest version (36.8.1) and the changes in #2679 seem to have fixed all of the warnings:
Screenshot 2024-01-10 at 10 54 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KenanYusuf KenanYusuf

Labels
Type: TypeScript Issues related to typescript or type definitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carbonrobot @KenanYusuf