Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps for React 18.3.0 #997

Closed
Shoreasg opened this issue Feb 11, 2023 · 2 comments
Closed

Remove defaultProps for React 18.3.0 #997

Shoreasg opened this issue Feb 11, 2023 · 2 comments

Comments

@Shoreasg
Copy link

Nuka Version: 5.41
React Version: 18.2.0
Chrome

Problem
Carousel: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. Getting this error due to this PR

jsx-eslint/eslint-plugin-react#2396
facebook/react#16210

Need to fix this before the release of react 18.3.0
@VanTanev
Copy link

VanTanev commented Jun 6, 2023

Just wanted to mention, we're now hitting this in nextjs 13.4 with app router - it's shipping a canary of React that has the deprecation warning.

Looking at the code, it seems to be a one-line change to fix it. I'll open a simple PR.

@VanTanev VanTanev mentioned this issue Jun 6, 2023
Closed
2 tasks
@carbonrobot
Copy link
Contributor

With the release of Nuka v8, defaultProps have been removed from the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated defaultProps warning in React >18.2.0 VanTanev/nuka-carousel
3 participants
@VanTanev @carbonrobot @Shoreasg