Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After bumping forest-express-sequelize version to 9.4.1 and forest-express to 10.4.0 description and submitButtonLabel are not available in smart actions options #1125

Closed
bennytaccardi opened this issue Nov 5, 2024 · 2 comments · Fixed by #1126
Closed

After bumping forest-express-sequelize version to 9.4.1 and forest-express to 10.4.0 description and submitButtonLabel are not available in smart actions options #1125

bennytaccardi opened this issue Nov 5, 2024 · 2 comments · Fixed by #1126

Comments

@bennytaccardi
Copy link
Contributor

Expected behavior

description and submitButtonLabel should be listed as available options in SmartActionsOptions interface.

Actual behavior

After bumping forest-express-sequelize version to 9.4.1 and forest-express to 10.4.0, these options works correctly but TS still is unable to check the existence of these two options

Failure Logs

photo_2024-11-05 14 42 46

Context

  • Package Version: 9.4.1
  • Express Version: 4.17.13
  • Sequelize Version: 6.29.0
  • Database Dialect: pg
  • Database Version: 8.4.2
@bennytaccardi bennytaccardi mentioned this issue Nov 5, 2024
Merged
5 tasks
@bennytaccardi
Copy link
Contributor Author

I already opened a PR 1126

@realSpok
Copy link
Contributor

realSpok commented Nov 5, 2024

Hello,
This is most likely missing from my contribution: #1123
thanks for the PR 🙏
I'm testing that right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(actions): add missing fields to actions options interface bennytaccardi/forest-express-sequelize
2 participants
@realSpok @bennytaccardi