Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add promise return for SmartFieldFilterer #1043

Conversation

JustinMartinDev
Copy link
Contributor

Definition of Done

As defined on forest-express the filter function of smart-fields can be async here

 const formattedCondition = await fieldFound
      .filter({
        where,
        condition,
      });

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@jeffladiray jeffladiray self-requested a review November 25, 2022 11:29
@jeffladiray
Copy link
Member

Thanks for your contribution 🙏

@jeffladiray jeffladiray merged commit 6d0b7d1 into ForestAdmin:main Nov 25, 2022
forest-bot added a commit that referenced this pull request Nov 25, 2022
## [9.0.2](v9.0.1...v9.0.2) (2022-11-25)

### Bug Fixes

* **type:** add promise return for `SmartFieldFilterer` ([#1043](#1043)) ([6d0b7d1](6d0b7d1))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants