Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): add FilterOperator enum #1040

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(type): add FilterOperator enum #1040

merged 1 commit into from
Nov 28, 2022

Conversation

JustinMartinDev
Copy link
Contributor

@JustinMartinDev JustinMartinDev commented Nov 23, 2022 •
edited
Loading

Definition of Done

General

Proposal based on filter-parser and filter-date-parser

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@JustinMartinDev
Copy link
Contributor Author

JustinMartinDev commented Nov 25, 2022 •
edited
Loading

news @jeffladiray ?

@jeffladiray
Copy link
Member

Yes, sorry for the delayed response.
It seems like you are missing quite a few operators, especially the one related to Date filtering (The complete list of operators supported is available here (On our new agent).

If you feel like updating this contribution with these, I'll happily merge it.
Otherwise, I can file a ticket on our end.

@jeffladiray jeffladiray self-requested a review November 25, 2022 15:24
@JustinMartinDev
Copy link
Contributor Author

JustinMartinDev commented Nov 27, 2022 •
edited
Loading

I amend my previous commit to include operator of this fie https://github.com/ForestAdmin/forest-express/blob/main/src/services/base-operator-date-parser.js

@jeffladiray fixed

@jeffladiray jeffladiray merged commit 17b47d9 into ForestAdmin:main Nov 28, 2022
@jeffladiray
Copy link
Member

Thanks you for this contribution 🙌

forest-bot added a commit that referenced this pull request Nov 28, 2022
@forest-bot
chore(release): 9.0.3 [skip ci]
d86e46b 
## [9.0.3](v9.0.2...v9.0.3) (2022-11-28)

### Bug Fixes

* **type:** add FilterOperator enum ([#1040](#1040)) ([17b47d9](17b47d9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffladiray jeffladiray jeffladiray approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinMartinDev @jeffladiray @forest-bot