Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): add "isSortable" to SmartFieldOptions interface #1012

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(type): add "isSortable" to SmartFieldOptions interface #1012

merged 1 commit into from
Sep 28, 2022

Conversation

JustinMartinDev
Copy link
Contributor

@JustinMartinDev JustinMartinDev commented Sep 27, 2022 •
edited
Loading

According to doc: https://docs.forestadmin.com/documentation/reference-guide/smart-fields/smart-field-examples/sort-by-smart-field, smart field option should allow to set property isSortable as optional boolean

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@arnaud-moncel arnaud-moncel changed the title Add "isSortable" to SmartFieldOptions interface fix(type): add "isSortable" to SmartFieldOptions interface Sep 28, 2022
jeffladiray
jeffladiray approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@jeffladiray jeffladiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙏

@jeffladiray jeffladiray merged commit 6a50a53 into ForestAdmin:main Sep 28, 2022
forest-bot added a commit that referenced this pull request Sep 28, 2022
@forest-bot
chore(release): 8.5.13 [skip ci]
15a6747 
## [8.5.13](v8.5.12...v8.5.13) (2022-09-28)

### Bug Fixes

* **type:** add "isSortable" to SmartFieldOptions interface ([#1012](#1012)) ([6a50a53](6a50a53))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.5.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffladiray jeffladiray jeffladiray approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinMartinDev @forest-bot @jeffladiray