Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore MacOS support #1

Closed
chrisbrickhouse opened this issue Oct 23, 2023 · 2 comments · Fixed by #14
Closed

Restore MacOS support #1

chrisbrickhouse opened this issue Oct 23, 2023 · 2 comments · Fixed by #14
Labels
technical debt A problem for the future

Comments

@chrisbrickhouse
Copy link
Member

In our chain of dependencies openai-whisper depends pyannote-audio depends onnxruntime-gpu>=1.16.0

onnxruntime-gpu does not support MacOS (issue). This dependency appears to have been added to pyannote-audio in the 3.0.1 release (issue).

For the moment we will need to drop plans for MacOS support. The short-term resolution is to pin pyannote-audio==3.0.0 but this is not ideal given the potential conflicts as other dependencies bump versions. The long-term solution would be upstream changes, but we have no control over what upstream does.

For the moment I will chalk this up as code debt given that I have no need to run this on Mac, but it will be a hurdle when we move towards an initial release.
@chrisbrickhouse chrisbrickhouse added the technical debt A problem for the future label Oct 23, 2023
chrisbrickhouse added a commit that referenced this issue Oct 23, 2023
@chrisbrickhouse
CI: Drop support from MacOS
266bbd1 
Pyannote.audio requires onnxruntime-gpu>=1.16.0 but on MacOS this module
is not supported.

Until this is resolved upstream, we cannot support MacOS. See #1
@JoFrhwld
Copy link
Member

fyi, it looks like pyannote has an open PR about this: pyannote/pyannote-audio#1540

@JoFrhwld
Copy link
Member

And, it's been released! https://github.com/pyannote/pyannote-audio/releases/tag/3.1.0

@chrisbrickhouse chrisbrickhouse changed the title MacOS not supported Restore MacOS support Feb 7, 2024
@chrisbrickhouse chrisbrickhouse mentioned this issue Feb 7, 2024
Closed
@chrisbrickhouse chrisbrickhouse mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt A problem for the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore MacOS support Forced-Alignment-and-Vowel-Extraction/fave-asr
2 participants
@JoFrhwld @chrisbrickhouse