Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are legitimate use cases for this library in production #115

Open
Milad opened this issue May 6, 2019 · 0 comments
Open

There are legitimate use cases for this library in production #115

Milad opened this issue May 6, 2019 · 0 comments

Comments

@Milad
Copy link

Milad commented May 6, 2019

Hello

The documentation states it clearly that this library shouldn't be used in production because it blocks the application. Which is true, except there are examples where you actually want to block the application and here is mine:

I have a node service that accepts requests, these requests come with a signed JWT, and in order to verify the signature I need the public key from the signing service. So when the first service starts, and before I allow express to receive requests, I want the service to load the public key from the signing service, and this module is very handy in this situation. The public key is fetched once only at the beginning of the application and that's why this module doesn't have a negative effect on my service at all, on the contrary, it saved the day for me.

What I suggest is to beside the warning, leave a room for the developer to choose what's good for their situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant