From 230160349de0dbf7eaffc8503940d290b0b8e02a Mon Sep 17 00:00:00 2001 From: Yishuo Wang Date: Tue, 6 Sep 2022 17:09:31 +0800 Subject: [PATCH] fix nano UT (#5650) --- .github/workflows/nano_unit_tests_pytorch.yml | 2 ++ .github/workflows/nano_unit_tests_tensorflow.yml | 2 ++ docs/readthedocs/source/doc/Nano/Overview/known_issues.md | 8 +++++++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nano_unit_tests_pytorch.yml b/.github/workflows/nano_unit_tests_pytorch.yml index c9d4cdda1b9..799bc81f7ea 100644 --- a/.github/workflows/nano_unit_tests_pytorch.yml +++ b/.github/workflows/nano_unit_tests_pytorch.yml @@ -98,6 +98,8 @@ jobs: $CONDA/bin/conda info bash python/nano/dev/build_and_install.sh linux default false pytorch pip install pytest + # fix issue, see https://github.com/intel-analytics/BigDL/blob/main/docs/readthedocs/source/doc/Nano/Overview/known_issues.md#ray-issues + pip install google-api-core==2.8.2 pip install ray[default]==1.11.0 prometheus_client==0.13.0 if [ ! -z "${{matrix.pytorch-version}}" ]; then pip install ${{matrix.pytorch-version}} -f https://download.pytorch.org/whl/torch_stable.html diff --git a/.github/workflows/nano_unit_tests_tensorflow.yml b/.github/workflows/nano_unit_tests_tensorflow.yml index 934a5ace197..b420ad5e8f6 100644 --- a/.github/workflows/nano_unit_tests_tensorflow.yml +++ b/.github/workflows/nano_unit_tests_tensorflow.yml @@ -81,6 +81,8 @@ jobs: $CONDA/bin/conda info bash python/nano/dev/build_and_install.sh linux default false tensorflow pip install pytest + # fix issue, see https://github.com/intel-analytics/BigDL/blob/main/docs/readthedocs/source/doc/Nano/Overview/known_issues.md#ray-issues + pip install google-api-core==2.8.2 pip install ray[default]==1.11.0 prometheus_client==0.13.0 source bigdl-nano-init bash python/nano/test/run-nano-tf-ray-tests.sh diff --git a/docs/readthedocs/source/doc/Nano/Overview/known_issues.md b/docs/readthedocs/source/doc/Nano/Overview/known_issues.md index bdef803913d..d5e30ef11d6 100644 --- a/docs/readthedocs/source/doc/Nano/Overview/known_issues.md +++ b/docs/readthedocs/source/doc/Nano/Overview/known_issues.md @@ -50,4 +50,10 @@ spec: ### **Nano keras multi-instance training currently does not suport tensorflow dataset.from_generators, numpy_function, py_function** -Nano keras multi-instance training will serialize TensorFlow dataset object into a `graph.pb` file, which does not work with `dataset.from_generators`, `dataset.numpy_function`, `dataset.py_function` due to limitations in TensorFlow. \ No newline at end of file +Nano keras multi-instance training will serialize TensorFlow dataset object into a `graph.pb` file, which does not work with `dataset.from_generators`, `dataset.numpy_function`, `dataset.py_function` due to limitations in TensorFlow. + +## **Ray Issues** + +### **protobuf version error** + +Now `pip install ray[default]==1.11.0` will install `google-api-core==2.10.0`, which depends on `protobuf>=3.20.1`. However, nano depends on `protobuf==3.19.4`, so if we install `ray` after installing `bigdl-nano`, pip will reinstall `protobuf==4.21.5`, which causes error.