Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Foodcritic/foodcritic
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.2.0
Choose a base ref
...
head repository: Foodcritic/foodcritic
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.3.0
Choose a head ref
  • 18 commits
  • 17 files changed
  • 2 contributors

Commits on Jul 7, 2017

  1. Fix the travis badge

    tas50 authored Jul 7, 2017
    Copy the full SHA
    97637b8 View commit details
  2. Chefstyle fixes

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 7, 2017
    Copy the full SHA
    b2d4584 View commit details
  3. Merge pull request #648 from Foodcritic/chefstyle

    Chefstyle fixes
    tas50 authored Jul 7, 2017
    Copy the full SHA
    1b622d5 View commit details

Commits on Jul 8, 2017

  1. Remove the Chef 11 FC033 test

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
    Copy the full SHA
    5d8e645 View commit details
  2. Add some comments to FC033 code

    It's chained which makes it hard to follow
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
    Copy the full SHA
    6de8e55 View commit details
  3. Make the alert name more obvious

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
    Copy the full SHA
    79de3ab View commit details
  4. Remove the Chef 11 support in the check

    Also add a comment explaining how flawed this logic is
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
    Copy the full SHA
    e638aeb View commit details

Commits on Jul 9, 2017

  1. Switch from yajl-ruby to ffi-yajl

    ffi-yajl is used by Chef already so this is one less requirement in ChefDK. yajl-ruby install size in macOS ChefDK is 3.8M
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 9, 2017
    Copy the full SHA
    a1dbaac View commit details
  2. Copy the full SHA
    b251281 View commit details
  3. Merge pull request #649 from Foodcritic/fc033

    Minor FC033 cleanup with comments
    tas50 authored Jul 9, 2017
    Copy the full SHA
    f6be63d View commit details
  4. Make sure we still error properly on bad JSON data

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 9, 2017
    Copy the full SHA
    4859358 View commit details
  5. Copy the full SHA
    5d799f9 View commit details
  6. Merge pull request #650 from Foodcritic/ffi_yajl

    Switch from yajl-ruby to ffi-yajl
    tas50 authored Jul 9, 2017
    Copy the full SHA
    e9677eb View commit details

Commits on Jul 12, 2017

  1. FC001 should not alert on node.run_state[:foo]

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
    Copy the full SHA
    b05f3d7 View commit details
  2. Update regression test for windows

    This was the bug I was fixed false alarming.
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
    Copy the full SHA
    367bf80 View commit details
  3. Merge pull request #653 from Foodcritic/nodestate

    FC001 should not alert on node.run_state[:foo]
    tas50 authored Jul 12, 2017
    Copy the full SHA
    9d3ef1a View commit details
  4. Release 11.3

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
    Copy the full SHA
    ff05c14 View commit details
  5. Merge pull request #654 from Foodcritic/11.3

    Release 11.3
    tas50 authored Jul 12, 2017
    Copy the full SHA
    408a1fc View commit details
Loading