-
Notifications
You must be signed in to change notification settings - Fork 153
Comparing changes
Open a pull request
base repository: Foodcritic/foodcritic
base: v11.2.0
head repository: Foodcritic/foodcritic
compare: v11.3.0
- 18 commits
- 17 files changed
- 2 contributors
Commits on Jul 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 97637b8 - Browse repository at this point
Copy the full SHA 97637b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2d4584 - Browse repository at this point
Copy the full SHA b2d4584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b622d5 - Browse repository at this point
Copy the full SHA 1b622d5View commit details
Commits on Jul 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5d8e645 - Browse repository at this point
Copy the full SHA 5d8e645View commit details -
Add some comments to FC033 code
It's chained which makes it hard to follow Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for 6de8e55 - Browse repository at this point
Copy the full SHA 6de8e55View commit details -
Make the alert name more obvious
Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for 79de3ab - Browse repository at this point
Copy the full SHA 79de3abView commit details -
Remove the Chef 11 support in the check
Also add a comment explaining how flawed this logic is Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for e638aeb - Browse repository at this point
Copy the full SHA e638aebView commit details
Commits on Jul 9, 2017
-
Switch from yajl-ruby to ffi-yajl
ffi-yajl is used by Chef already so this is one less requirement in ChefDK. yajl-ruby install size in macOS ChefDK is 3.8M Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for a1dbaac - Browse repository at this point
Copy the full SHA a1dbaacView commit details -
Configuration menu - View commit details
-
Copy full SHA for b251281 - Browse repository at this point
Copy the full SHA b251281View commit details -
Merge pull request #649 from Foodcritic/fc033
Minor FC033 cleanup with comments
Configuration menu - View commit details
-
Copy full SHA for f6be63d - Browse repository at this point
Copy the full SHA f6be63dView commit details -
Make sure we still error properly on bad JSON data
Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for 4859358 - Browse repository at this point
Copy the full SHA 4859358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d799f9 - Browse repository at this point
Copy the full SHA 5d799f9View commit details -
Merge pull request #650 from Foodcritic/ffi_yajl
Switch from yajl-ruby to ffi-yajl
Configuration menu - View commit details
-
Copy full SHA for e9677eb - Browse repository at this point
Copy the full SHA e9677ebView commit details
Commits on Jul 12, 2017
-
FC001 should not alert on node.run_state[:foo]
Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for b05f3d7 - Browse repository at this point
Copy the full SHA b05f3d7View commit details -
Update regression test for windows
This was the bug I was fixed false alarming. Signed-off-by: Tim Smith <tsmith@chef.io>
Configuration menu - View commit details
-
Copy full SHA for 367bf80 - Browse repository at this point
Copy the full SHA 367bf80View commit details -
Merge pull request #653 from Foodcritic/nodestate
FC001 should not alert on node.run_state[:foo]
Configuration menu - View commit details
-
Copy full SHA for 9d3ef1a - Browse repository at this point
Copy the full SHA 9d3ef1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff05c14 - Browse repository at this point
Copy the full SHA ff05c14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 408a1fc - Browse repository at this point
Copy the full SHA 408a1fcView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v11.2.0...v11.3.0