-
Notifications
You must be signed in to change notification settings - Fork 251
Frequency Lists now "undefined" #1058
Comments
Nice, thanks for the fix! I'm not too familiar with the update process; I assume Chrome will automatically update the extension at some point to reflect the change? |
Chrome will auto-update when a new release is out. Is this a usage impediment for either of you that would merit a patch release sooner, or would it be fine to wait until the next full release? (next full testing release ~1 week; stable ~2 weeks) |
If it's not too much trouble I would appreciate a patch release :^) |
Seconded for the patch release if possible 👍 |
Same issue here, waiting for patch release 🙏 |
Fix is queued for 20.11.1.1 patch release; I believe @FooSoft has been busy recently, and I don't handle official release deployment. Apologies for any issues; I can create an unofficial temporary standalone build that you might be able to manually install depending on your browser, if that's helpful. (It would require dictionary/settings reinstallation though.) |
No worries, I understand! Looking at the fix, could I just temporarily recompile the frequency list with the field name changed? as in change change this: to this? Otherwise, I assume the patch release will get posted any day now. For me it might be simpler to just keep manually looking up that freq list as needed, rather than worrying about uninstalling/reinstalling/etc |
The validation process will probably disallow the |
ah, yep |
Sorry for the delay! I've been drowning in emails and did not notice this earlier. Patched version has been queued for release. |
Hello,
Thank you for all your hard work on Yomichan. With the new update, basic frequency lists still work fine.
For example, a frequency list with the format of ["認める","freq",714] works.
However, frequency lists that contain extra fields such as "reading" now show up as "undefined", when they would display properly before.
For example, a frequency list with the format of ["炊爨", "freq", {"reading": "すいさん", "frequency": 44019}] does not display properly anymore.
Could this issue be investigated and fixed? Thank you.
The text was updated successfully, but these errors were encountered: