Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possibly issue with strict mode #480

Closed
DanielRuf opened this issue Feb 21, 2018 · 3 comments
Closed

possibly issue with strict mode #480

DanielRuf opened this issue Feb 21, 2018 · 3 comments

Comments

@DanielRuf
Copy link

The AMD / UMD wrapper has an undefined root in specific cases where strict mode is used.
In this cases we have to set root to window if it is defined.

I'll prepare a testcase which demonstrates this (this is often the case with Gulp, webpack and other solutions).
@nolimits4web
Copy link
Contributor

Facing same issue, also found this one #481

@DanielRuf
Copy link
Author

DanielRuf commented Feb 21, 2018 •
edited
Loading

Something like bebraw/libumd@f43a331 is needed.

dimsemenov/PhotoSwipe#1413

@DanielRuf
Copy link
Author

More references:

fians/Waves#181
jonathantneal/svg4everybody#162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielRuf @nolimits4web