#29/add money commas #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serpient
requested changes
Oct 18, 2019
There was a problem hiding this comment.
I think we can add a few more test cases and once thats passing, it should be good to go.
Also regarding commits, it's a little easier to read when you have a 70 character heading and then the rest of the description a line after. Or not, it gets cut off by github like so:
You can practice your rebasing if you wanted to adjust the commits!
src/utilities/price.test.js
Outdated
| @@ -10,7 +10,7 @@ describe('Price Formatting', () => { | |||
| expect(convertPenniesToDollars(999)).toEqual("9.99"); | |||
| expect(convertPenniesToDollars(1000)).toEqual("10.00"); | |||
| expect(convertPenniesToDollars(10000)).toEqual("100.00"); | |||
| expect(convertPenniesToDollars(100000)).toEqual("1000.00"); | |||
| expect(convertPenniesToDollars(100000)).toEqual("1,000.00"); | |||
There was a problem hiding this comment.
Can we add a few more tests here to make sure it's working as expected?
Add these cases please:
10,000
100,000
1,000,000
ffchiangster
force-pushed
the
#29/add-money-commas
branch
from
220ff39 to
0716fd4
Compare
…converting pennies to dollars. Updated all test files now with commas in the dollar values.
…er prices are correctly converted to integers for the form.
ffchiangster
force-pushed
the
#29/add-money-commas
branch
from
0716fd4 to
89a64f5
Compare
serpient
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.