Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] comma separated values for money #29

Open
serpient opened this issue Oct 1, 2019 · 0 comments
Open

[UX] comma separated values for money #29

serpient opened this issue Oct 1, 2019 · 0 comments
Assignees
@ffchiangster
Labels
good first issue Good for newcomers

Comments

@serpient
Copy link
Collaborator

serpient commented Oct 1, 2019 •
edited
Loading

Issue:

Currently, money is rendering like this

"$50000.00"

Desired Outcome:
It would be nice to see it like this:

"$50,000.00"

Relevant File:
src/utilities/price
src/utilities/price.test.js
@serpient serpient added the good first issue Good for newcomers label Oct 1, 2019
@ffchiangster ffchiangster self-assigned this Oct 2, 2019
ffchiangster added a commit that referenced this issue Oct 18, 2019
@ffchiangster
#29/add-money-commas: updated tests for dataAdapter and the dataAdapt…
0db9f50 
…er to ensure that longer prices are correctly converted to integers for the form.
ffchiangster added a commit that referenced this issue Oct 18, 2019
@ffchiangster
#29/add-money-commas: made price.js tests more robust by adding in lo…
d2d60d8 
…nger dollar and penny amounts.
ffchiangster added a commit that referenced this issue Oct 18, 2019
@ffchiangster
#29/add-money-commas: added tests to include cent amounts.
220ff39
ffchiangster added a commit that referenced this issue Oct 18, 2019
@ffchiangster
#29/add-money-commas: added tests to include cent amounts.
0716fd4
serpient added a commit that referenced this issue Oct 18, 2019
@serpient
Merge pull request #33 from Focal-App/#29/add-money-commas
b97b417 
#29/add money commas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffchiangster ffchiangster

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffchiangster @serpient