Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repeat with keywords causes scalar indexing #1442

Open
DomCRose opened this issue Jul 21, 2023 · 0 comments
Open

repeat with keywords causes scalar indexing #1442

DomCRose opened this issue Jul 21, 2023 · 0 comments
Labels
ChainRules adjoint -> rrule, and further integration

Comments

@DomCRose
Copy link
Contributor

xref: JuliaDiff/ChainRules.jl#645 (comment)

Making this since Zygote currently doesn't use the ChainRules rrules for repeat anyway.

Guessing best approach here would be to fix it in ChainRules first then swap Zygote over to the ChainRules rrules.

A useful gist to this end from @mcabbott: https://gist.github.com/mcabbott/80ac43cca3bee8f57809155a5240519f
@ToucheSir ToucheSir added the ChainRules adjoint -> rrule, and further integration label Jul 21, 2023
@ToucheSir ToucheSir mentioned this issue Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChainRules adjoint -> rrule, and further integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ToucheSir @DomCRose