Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @nograd and dropgrad in favour of ChainRulesCore.@non_differentiable and ChainRulesCore.ignore_derivatives #1235

Closed
ToucheSir opened this issue Jun 3, 2022 · 0 comments · Fixed by #1249
Closed

Deprecate @nograd and dropgrad in favour of ChainRulesCore.@non_differentiable and ChainRulesCore.ignore_derivatives #1235

ToucheSir opened this issue Jun 3, 2022 · 0 comments · Fixed by #1249
Labels
ChainRules adjoint -> rrule, and further integration up for grabs anyone is welcome to contribute with a PR to fix the issue

Comments

@ToucheSir
Copy link
Member

The ChainRules equivalents work just as well, are more broadly applicable and switching to them will let us remove more Zygote-isms.
@ToucheSir ToucheSir added the up for grabs anyone is welcome to contribute with a PR to fix the issue label Jun 3, 2022
@ToucheSir ToucheSir changed the title Deprecate @nograd and dropgrad in favour of ChainRulesCore.@non_differentiable and ChainRulesCore.@ignore_derivatives Deprecate @nograd and dropgrad in favour of ChainRulesCore.@non_differentiable and ChainRulesCore.ignore_derivatives Jun 3, 2022
This was referenced Jun 17, 2022
Merged
Merged
@mcabbott mcabbott added the ChainRules adjoint -> rrule, and further integration label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChainRules adjoint -> rrule, and further integration up for grabs anyone is welcome to contribute with a PR to fix the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate Zygote.@nograd mzgubic/Zygote.jl
2 participants
@ToucheSir @mcabbott