Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinions on next release #11

Open
tpeulen opened this issue Aug 23, 2019 · 5 comments
Open

Opinions on next release #11

tpeulen opened this issue Aug 23, 2019 · 5 comments

Comments

@tpeulen
Copy link
Member

tpeulen commented Aug 23, 2019

Since the last release in 2018 the the calculation of distance distributions among other features has been added to LabelLib.

If there are no new features planned in the near future, it may be time for a new release.

@mdimura
Copy link
Member

mdimura commented Aug 26, 2019

We still probably should change all the std::array<> and std::vector<> in the interfaces to the Eigen:: equivivalents to achieve better consistency. It will change the API. I will probably not be able to do it in the next 2 weeks, but later I could implement that. Should we postpone the release until then or just make another release?

@tpeulen
Copy link
Member Author

tpeulen commented Aug 27, 2019

I think consistency is a good idea. I don't know about Pybind11 but in SWIG Eigen vectors and arrays can be directly mapped to numpy arrays. If possible, mapping to python lists could be avoided, as a direct map from Eigen -> Numpy array could be more efficient as opposed to Eigen -> List -> Numpy.

@mdimura
Copy link
Member

mdimura commented Aug 27, 2019

Yes, Pybind11 maps Eigen -> Numpy by default.

@tpeulen
Copy link
Member Author

tpeulen commented Aug 28, 2019

Great, I think the support of Python lists can be dropped. Mapping Eigen3 arrays to numpy should be anyway more performant.

@tpeulen
Copy link
Member Author

tpeulen commented Sep 22, 2019

For the next release we could/should link labellib to Zenodo (see: link). This way, LabelLib gets a DOI and could be cited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants