Removed duplicated enum from the core and first pass of static API documentation. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 21, 2016 10:14
Duplicated failing test AwaStaticClient_Create_and_Read_Operation_for_Object_and_Resource and changed it to read from the resource path rather than object instance. Temporary disabled the test that reads from the object instance. Signed-off-by: Roland Bewick <[email protected]>
…rSession To ensure calling AwaChangeSet_GetClientSession / AwaChangeSet_GetServerSession will return NULL if the wrong session type is requested. Ref: FLOWDM-694 Signed-off-by: Roland Bewick <[email protected]>
Ref: FLOWDM-695 Signed-off-by: Roland Bewick <[email protected]>
…cumentation. Replaced core Operations enum with AwaResourceOperations and removed the mapping between the two. Added doxygen for each of the static API functions, public types and enumerations, as well as examples and a brief overview in awa/static.h. Signed-off-by: Roland Bewick <[email protected]>
ghost
added this to the
| * @return NULL if the client is invalid or the resource instance does not exist for the specified | ||
| * object, object instance, resource and resource instance IDs. | ||
| */ | ||
| void * AwaStaticClient_GetResourceInstancePointer(AwaStaticClient * client, AwaObjectID objectID, AwaObjectInstanceID objectInstanceID, AwaResourceID resourceID, AwaResourceInstanceID resourceInstanceID); |
There was a problem hiding this comment.
@seank-img AwaStaticClient * client was missing from this function
cdewbery
pushed a commit
that referenced
this pull request
Mar 21, 2016
Removed duplicated enum from the core and first pass of static API documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced core Operations enum with AwaResourceOperations and removed the mapping between the two.
Added doxygen for each of the static API functions, public types and enumerations, as well as examples and a brief overview in awa/static.h.
Signed-off-by: Roland Bewick [email protected]