-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AwaStaticClient_ResourceChanged #69
Conversation
}; | ||
|
||
|
||
void callbackHandler(const AwaChangeSet * changeSet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs assertions and hardcoded values removed
The tests for this feature don't need threads - try this:
This would be preferable to multiple threads, which can be difficult to maintain and understand. |
@david-antliff-imgtec You don't need a thread for steps 3 and 4, but I think you still need a thread to create the initial observation, as the AwaServerObserveOperation_Perform() function is a blocking operation and won't complete until it times out (resulting in a error) or succeeds which requires AwaStaticClient_Process() to be called called. for example:
|
One working test for AwaStaticClient_ResourceChanged is in place but it needs to be cleaned up and parameterised. Added a temporary mapping between Lwm2mResult and AwaLwm2mError although these enums should really be combined. Renamed some wrongly spelt variables in test_client.cc Signed-off-by: Roland Bewick <[email protected]>
Removed deprecated definition->Handlers.Read == NULL check Removed AwaLwm2mResult_ToAwaLwm2mError (unused and untested) Parameterised observe test for AwaStaticClient_ResourceChanged for all single instance resource types.. Signed-off-by: Roland Bewick <[email protected]>
Signed-off-by: Roland Bewick <[email protected]>
Signed-off-by: Roland Bewick <[email protected]>
…multiple threads Signed-off-by: Roland Bewick <[email protected]>
Added AwaStaticClient_ResourceChanged
@chris-dewbery-imgtec yep, fair comment, we missed that. |
One working test for AwaStaticClient_ResourceChanged is in
place but it needs to be cleaned up and parameterised.
Added a temporary mapping between Lwm2mResult and AwaLwm2mError
although these enums should really be combined.
Renamed some wrongly spelt variables in test_client.cc
Signed-off-by: Roland Bewick [email protected]