Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide build-time switch to disable JSON support. #61

Merged
merged 2 commits into from
Mar 15, 2016

Conversation

DavidAntliff
Copy link
Collaborator

This patch provides a mechanism to omit JSON support (and libjsmn dependency). By default, JSON support is included.

To build without JSON support, set the relevant CMAKE option with:

make CMAKE_OPTIONS=-DWITH_JSON=OFF

Ref: FLOWDM-693
Signed-off-by: David Antliff [email protected]

This patch provides a mechanism to omit JSON support (and libjsmn dependency). By default, JSON support is included.

To build without JSON support, set the relevant CMAKE option with:

    make CMAKE_OPTIONS=-DWITH_JSON=OFF

Ref: FLOWDM-693
Signed-off-by: David Antliff <[email protected]>
@DavidAntliff
Copy link
Collaborator Author

Retest this please

1 similar comment
@DavidAntliff
Copy link
Collaborator Author

Retest this please

…cmake.

There is some difference between cmake 2.8.12 and 3.2.2 that results in LIBJSMN_INCLUDE_DIR being set to a null string by get_property(). This patch removes use of get_property in this case, ensuring that the variable has the correct value.

Signed-off-by: David Antliff <[email protected]>
seank-img pushed a commit that referenced this pull request Mar 15, 2016
Provide build-time switch to disable JSON support.
@seank-img seank-img merged commit 1ce65de into ConnectivityFoundry:master Mar 15, 2016
@DavidAntliff DavidAntliff deleted the with-json branch March 18, 2016 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants