Untangle static api dependencies #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Dewbery <[email protected]>
Signed-off-by: Chris Dewbery <[email protected]>
Signed-off-by: Chris Dewbery <[email protected]>
Signed-off-by: Chris Dewbery <[email protected]>
|
Can one of the admins verify this patch? |
| @@ -153,7 +153,7 @@ static int Lwm2mBootstrap_EndpointHandler(int type, void * ctxt, AddressType * a | |||
|
|
|||
| static void Lwm2mBootstrap_TransactionCallback(void * context, AddressType * addr, const char * responsePath, int responseCode, ContentType contentType, char * payload, int payloadLen) | |||
| { | |||
| if (responseCode >= Lwm2mResult_Success && responseCode <= Lwm2mResult_SuccessContent) | |||
| if (responseCode >= AwaLwm2mResult_Success && responseCode <= AwaLwm2mResult_SuccessContent) | |||
There was a problem hiding this comment.
Missing braces (style)
|
Reviewed, +1 contingent on comments being addressed (or at least considered) |
|
Unfortunately I don't have access to sean's static-api branch, so I will merge this pull request, then create another one for the remaining changes. |
cdewbery
pushed a commit
that referenced
this pull request
Mar 14, 2016
Untangle static api dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static API header files were not actually usable due to the fact they included the Lwm2m core headers, which are not "installed" by Cmake. I have rearranged things so that the core now includes and moved all the required object files to libawa_static.a