Fix default pmin value as this was preventing notifications on the cl… #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient ipc The default pmin value was set to -1 in the server object. The min is used to delay notifications and is treated as unsigned so -1 results in a very long delay. This value was being used when sending notifications via the client IPC, which essentially prevented any client application from receiving notifications. I have chosen "0" as the default, which results in no delay. beware that this may result in the flooding of notifications in the case where pmin is not configured appropriately. In my opinion pmin/pmax should have no impact at all for the IPC, but we can address that issue at another time. Ref: FLOWDM-686 Signed-off-by: Chris Dewbery <[email protected]>
|
+1 |
ghost
added
the
ghost
pushed a commit
that referenced
this pull request
Mar 14, 2016
Fix default pmin value as this was preventing notifications on the cl…
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default pmin value as this was preventing notifications on the client ipc
The default pmin value was set to -1 in the server object.
The min is used to delay notifications and is treated as unsigned
so -1 results in a very long delay. This value was being used when
sending notifications via the client IPC, which essentially prevented
any client application from receiving notifications.
I have chosen "0" as the default, which results in no delay.
beware that this may result in the flooding of notifications in the
case where pmin is not configured appropriately. In my opinion
pmin/pmax should have no impact at all for the IPC, but we can
address that issue at another time.
Ref: FLOWDM-686
Signed-off-by: Chris Dewbery [email protected]