Fix Static API define behaviour before init and add test case #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[valgrind] |
| @@ -34,7 +34,19 @@ TEST_F(TestStaticClientHandler, AwaStaticClient_SetResourceOperationHandler_Inva | |||
| { | |||
| auto client = AwaStaticClient_New(); | |||
| ASSERT_TRUE(client != NULL); | |||
| EXPECT_EQ(AwaError_Success, AwaStaticClient_DefineObject(client, 9999, "TestObject", 0, 1)); | |||
|
|
|||
| EXPECT_EQ(AwaError_DefinitionInvalid, AwaStaticClient_SetResourceOperationHandler(client, 9999, 1, handler)); | |||
There was a problem hiding this comment.
Perhaps it would be better to create a new error code, suggest AwaError_StaticClientNotInitialized? Then users know that their calls are failing because of that reason.
seank-img
force-pushed
the
static-api-fixes
branch
from
561e9cd to
26a7d74
Compare
seank-img
force-pushed
the
static-api-fixes
branch
from
26a7d74 to
b5b353b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.