Static API changes #124
Merged
Static API changes #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2016 12:27
…n Object Operation handler. Add AwaStaticClient_SetObjectOperationHandler(). Deprecate AwaStaticClient_DefineObjectWithHandler(). Signed-off-by: David Antliff <[email protected]>
… a Resource Operation handler, or storage pointer.
Add AwaStaticClient_DefineResource().
Add AwaStaticClient_SetResourceOperationHandler().
Add AwaStaticClient_SetResourceStorageWithPointer().
Add AwaStaticClient_SetResourceStorageWithPointerArray().
Deprecate AwaStaticClient_DefineResourceWithHandler().
Deprecate AwaStaticClient_DefineResourceWithPointer().
Deprecate AwaStaticClient_DefineResourceWithPointerArray().
Signed-off-by: David Antliff <[email protected]>
| ASSERT_EQ(AwaError_Success, AwaStaticClient_DefineResource(client_, 7997, 1, "TestResource", AwaResourceType_Opaque, 1, 1, AwaResourceOperations_ReadWrite)); | ||
| EXPECT_EQ(AwaError_StaticClientInvalid, AwaStaticClient_SetResourceStorageWithPointer(NULL, 7996, 1, &o, sizeof(o), 0)); | ||
| EXPECT_EQ(AwaError_DefinitionInvalid, AwaStaticClient_SetResourceStorageWithPointer(client_, 7997, 1, &o, 0, 0)); | ||
| EXPECT_EQ(AwaError_DefinitionInvalid, AwaStaticClient_SetResourceStorageWithPointer(client_, 7997, 1, NULL, 0, 0)); |
There was a problem hiding this comment.
Need to test AwaStaticClient_SetResourceStorageWithPointer on a resource that hasn't been defined using AwaStaticClient_DefineResource:
ASSERT_EQ(AwaError_DefinitionInvalid, AwaStaticClient_SetResourceStorageWithPointer(client_, 7996, 1, &o, sizeof(o), 0));
|
+1 when comments addressed |
…jects and resources in the Static API. This is now consistent with the Gateway API, where Name follows the IDs. Add CMakeLists.txt for examples/tutorials, to ensure they are built alongside the API. Signed-off-by: David Antliff <[email protected]>
DavidAntliff
force-pushed
the
static-api-changes
branch
from
40b5d4c to
1a446eb
Compare
Signed-off-by: David Antliff <[email protected]>
DavidAntliff
force-pushed
the
static-api-changes
branch
from
63b6da7 to
8fdaae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are intended to improve consistency with the Gateway API, and separate the concerns of Object/Resource definition from how the entity is managed or stored. This results in the deprecation of some existing API functions. These deprecated functions will be removed after 0.1.8 has been released.
Also includes a minor documentation update by reserving a section for "Best Practices".