Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Core handlers and add error messages for handlers #104

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

seank-img
Copy link
Contributor

Signed-off-by: Sean Kelly [email protected]

@seank-img
Copy link
Contributor Author

@pratik-prajapati-imgtec was returning an incorrect AwaResult for the write handler (https://github.com/pratik-prajapati-imgtec/libobjects-1/commit/5815d542614d8fc71d420dd58af5d74342c60324#commitcomment-16946253) but there was no error message in the core to indicate this.

@DavidAntliff
Copy link
Collaborator

Is it worth adding some tests now to cover this sort of behaviour?

@seank-img seank-img added this to the 0.1.6 milestone Apr 5, 2016
@seank-img
Copy link
Contributor Author

@david-antliff-imgtec currently the result returned in the handler is not passed through to the coap - so there is no feedback to a server about what kind of error occured in the handler leaving nothing to test. When/If we do this is where tests need to be written. Other than that there is testing the printing of error messages?

@DavidAntliff
Copy link
Collaborator

If you think it's worth testing for expected error messages, then you can use the CaptureStderr class in the test framework, otherwise if you don't think it's necessary I'm happy to merge this.

@DavidAntliff DavidAntliff merged commit 099462f into ConnectivityFoundry:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants