Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

may be guards of ipv6_label/2 are wrong?. #1

Open
shun159 opened this issue Dec 1, 2014 · 0 comments
Open

may be guards of ipv6_label/2 are wrong?. #1

shun159 opened this issue Dec 1, 2014 · 0 comments

Comments

@shun159
Copy link
Contributor

shun159 commented Dec 1, 2014

ipv6_flabel is 20bit.
but byte_size(val) == 20, may should be bit_size(val) == 20.

https://github.com/FlowForwarding/of_msg_lib/blob/master/src/of_msg_lib_v4.erl#L914
https://github.com/FlowForwarding/of_msg_lib/blob/master/src/of_msg_lib_v5.erl#L1036

I fixed as follows:
https://github.com/shun159/of_msg_lib/blob/fix/ipv6_label_guard/src/of_msg_lib_v5.erl#L1036
https://github.com/shun159/of_msg_lib/blob/fix/ipv6_label_guard/src/of_msg_lib_v4.erl#L914

regards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shun159