Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API broken? #14

Open
PottiMc opened this issue Sep 19, 2023 · 7 comments
Open

API broken? #14

PottiMc opened this issue Sep 19, 2023 · 7 comments

Comments

@PottiMc
Copy link

PottiMc commented Sep 19, 2023

Hi FlorianSW,
it looks like the Grohe API changed somehow since a lot of programs associated with your API access seem to fail. I tested the Homebridge-Addon, the NodeRed-Addon and (my standard) the binding for Openhab. All three can't access the API anymore. I am not a developer and for that will have a hard time to understand everything you developed. Would you mind having a short look at your code, maybe you can see what changed in 2 minutes?

@PottiMc
Copy link
Author

PottiMc commented Sep 19, 2023

@FlorianSW

@FlorianSW
Copy link
Owner

Hi pottimc,

Unfortunately, I do not have access to a Grohe account with a device anymore. Therefore I'm not really able to take a look into that. Without access to a live account with an actual existing device, there is no way to inspect the API results for me, which is crucial to find out what the difference of the current API and the implementation of this repository is.

@PottiMc
Copy link
Author

PottiMc commented Sep 20, 2023

Is there a way to contact you in private? I could provide you with my credentials for a limited amount of time if you are willing to at least have a look at it. Would be pretty nice to get my Openhab Binding running again but I am definitely not a developer and would start at 0.

@PottiMc
Copy link
Author

PottiMc commented Sep 20, 2023

Looks like the NodeRed version fixed it somehow:
windkh/node-red-contrib-grohe-sense#12

@FlorianSW
Copy link
Owner

I've looked at the API myself with some credentials I got "randomly submitted" 😅
The change seems to be pretty small, at least from what I found so far. The 3.0.0 release contains these changes:
https://github.com/FlorianSW/grohe-ondus-api-java/releases/tag/3.0.0

One thing: Until now, the getApplianceData() function will always return the data grouped by day, the API seems to support to have granularity in hours as well. Not sure if that is needed 🤷

@FlorianSW
Copy link
Owner

The sync to maven central (of version 3.0.0) seems, however, to be a bit slow.

@PottiMc
Copy link
Author

PottiMc commented Sep 21, 2023

Thank you very much for that fast fix! I can't test it until Maven is ready to go. We will see 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants