Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: aria-hidden=true should be removed #20

Open
titanism opened this issue Jan 9, 2023 · 1 comment
Open

bug: aria-hidden=true should be removed #20

titanism opened this issue Jan 9, 2023 · 1 comment

Comments

@titanism
Copy link

titanism commented Jan 9, 2023

This line needs to be removed:

markdown-it-github-headings/index.js

Line 62 in d4c008d

linkOpen.attrSet('aria-hidden', 'true')

Note that you already have aria-hidden=true on the SVG, which should suffice.

Google's PageSpeed Insights deems this current behavior negatively.

Screen Shot 2023-01-08 at 8 17 14 PM
@titanism
Copy link
Author

titanism commented Jan 9, 2023

Someone should probably also notify GitHub support of this since this is mirrored from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titanism