Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto downloader #36

Closed
xx255q opened this issue Jul 4, 2020 · 45 comments
Closed

Add auto downloader #36

xx255q opened this issue Jul 4, 2020 · 45 comments
Labels
feature request Add this feature to Novel-Grabber

Comments

@xx255q
Copy link

xx255q commented Jul 4, 2020

Like FMD/FMD2 you search for a series then add it a list where every so often it will look for new chapters

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

I don't know what FMD/FMD2 is, could you elaborate a bit more what exactly you have in mind? It sounds to me like you want to have a library where you can add novels and it checks every so often for new chapters. I'm a bit confused about the auto downloader part in the title. Is it supposed to automatically replace the previously created EPUB with an updated one?

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020

I am sorry for being unclear. So for example i would look up a series and download all the available chapters, then I would click a button to track the series and like you said, every so often it would check for a new chapter. It does not need to replace, just make a new file that ideally would show its different like chapters: chapter 1 is before chapter 2. That way you would not have to go and manually sort them so you can read correctly.

Also that wuxiaworld site did not work i dont know if you can fix that?

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

I don't know how viable that approach would be. Same reason I thought about adding a library function but scraping the idea later. What you're describing would be best implemented as a self contained reader which tracks already read chapters and adds new ones when they become available. I'm not sure how that would work with NG and the EPUBs it creates, they're pretty bad for small 'updates'. (A new 'main' file which replaces the old or new smaller ones).
And when thinking about that, I don't see how much worth a library is, when it just keeps track of new chapters. There are probably different tools for that already.

Which site? Wuxiaworld.com or Wuxiaworld.site

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020

Wuxiaworld.com

And i was wondering why do you bundle the way you do? all the other downloader for different thing such as comics and manga do it by a per chapter basis because it would run into the same issue you talked about have to re make it every time. If you gave the option to download section instead of what you do now it would fix the issue. The manga downloader HakuNeko has a feature that when you click on the series it gives a list of all the chapters and also the file you already have downloaded which would be nice to have if you let people file multiple files for each chapter instead of all in one.

https://github.com/dazedcat19/FMD2 is the link for the manga downloader and tracker, I quite like how it does things and maybe it will give you a better idea of what I am talking about. In my case I don't need a reader, Komga comic server does that for me. In the end it is your choice and there are other things to work on just understand that if you are able to set up tracking/auto downloading it would be huge

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

The point of NG is to be able to read a webnovel conveniently on your eReader of choice. They all work with EPUBs so it's the perfect format to use for this. It's just not ideal for when you are caught up with a running novel. I think people only download new chapters in larger chunks when they have amassed a certain size of backlog and not short single chapters, I personally don't see the point of that. The only application I can think of would be to download new chapters of various different novels and put them together in a single file to get a comfortable reading experience.
An indicator to show the last downloaded chapter of a novel has merit through. Basically a history of downloaded novels/chapters.

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

Okay. How about this:
On the automatic tab, after you have fetched the novel info, you get the option to save/favourite it. This will add it to the library (a new tab). For each novel you get the basic meta info and the chapter number of the last downloaded chapter along with the number of the newest online. It will check the web page in regular intervals for updates. There will be a button to download all elapsed chapters to get caught up again (in a single file) and another selection to set up an auto download. Along with a save directory, you can specify how often you want it to create a file. For example, you only want a new one when 5 chapters were released. Maybe even make it send an email notification(with optional attachment) when it creates one.

@Flameish Flameish added the feature request Add this feature to Novel-Grabber label Jul 6, 2020
@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

The 2nd half is correct.

  • The library lists the info of all added novels and polls the websites for updates in the background every so often.
  • You get a 'manual' button to download all new chapters of a novel, from the previous last downloaded to the newest released combined in 1 file.
  • Then you can also (optional) set the novel to auto downloading and set the limit to 5 chapters, it will create a new file with just those 5 new chapters and sends you a notification or the whole file per email or something. Over the next week the author releases another 5 new ones, now NG creates a new file with just those 5.
    Like you mentioned, this option is for people who want the newest chapters right away.

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

For the gui I was thinking along the lines of this with a popup window to setup up the auto downloading.

Untitled
I would plan to support CLI too.

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

This would be the library/favorites tab yes. I would probably add a new 'star' button on the automatic grabbing tab to add that novel.

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 6, 2020

Should be pretty easy. I did quite a bit of code refactoring for the CLI update which I can now use much easier for this and I had a polling system in place before but removed it. No idea about the email part but I think it will be fun to figure out. I don't want to make any promises but it should be done in a few days depending if I find the time.

Wuxiaworld.com works perfectly fine for me. Can you post some console log etc?

@xx255q
Copy link
Author

xx255q commented Jul 6, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 7, 2020

Both will be part of the library "system".
Also you can try to use the headless browser option to bypass cloudflare.

@xx255q
Copy link
Author

xx255q commented Jul 7, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

Check out v2.8.0

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

Threshold 1 means it there is a new chapter. 0 means you're up-to-date.
It does creat a folder for the file but the whole naming convention needs a bit more fine tuning. I will probably add a library settings tab to change stuff like this. Same goes for the scan frequency. (its 20 minutes at the moment)

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

I'm taking a look at the save location, it should be: ../ Novel-Grabber/<title>/file.epub
I had to remove the spaces in the filename to be able to send them per email. Gonna fix it for non-auto grabbing to have spaces again.

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

Isn't this what you mean ../ Novel-Grabber/<title>/file.epub ? Or do you mean each epub will be put into its own subdirectory again?

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

I'm a bit confused. Are you talking about different novels getting their own folder (because they do) or the auto-downloaded files OF a novel get their own sub directories inside its "series" folder?

Currently the structure looks like this:

Screenshot from 2020-07-09 16-37-10
Screenshot from 2020-07-09 16-37-29

And this is how it would look like if I understand you correctly:

Screenshot from 2020-07-09 16-39-39
Screenshot from 2020-07-09 16-40-08

How would the 2nd be better than the first?

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

Will be fixed in the next release. First screenshots are from 2.8.1

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

I would need to take a look at available pdf libraries. Not sure how compatible they are with HTML(some even broken #23)
It's at the bottom of planned things for now.

@Jakgab617
Copy link

Hello,

I'd like some clarifications, the saving of files in each folder, is this for all downloads? Or only those items on the the favorite folder and tagged for auto-updates?

@Flameish
Copy link
Owner

Flameish commented Jul 9, 2020

Only for favourites tagged for auto-grabbing right now.

@Jakgab617
Copy link

Thank you. I'd like to request to keep it that way as I do not see the benefit of creating different folders for single epubs.

@xx255q
Copy link
Author

xx255q commented Jul 9, 2020 via email

@Jakgab617
Copy link

I am pertaining for those of us who do not download mangas, comics or even series or follow/download novels while they are on-going. That is why I requested to just keep the creation of file folders to those who put it in their config.

For book library organization or file format changes I have been a user of calibre for years. A lot of novel compilers use it within their program. In fact, for the things you have asked for, I can think of 2 available programs that is doing it and works in cli or within calibre as a plugin.

The reason I am here in NG is because of its ability in java enabled sites and configuring the grabber on your own for different websites. The ease of use and simplicity of the program is a big plus for me. And I really appreciate the author's efforts in integrating the cli.

@xx255q
Copy link
Author

xx255q commented Jul 10, 2020 via email

@Flameish
Copy link
Owner

There is no history right now. Only if you enabled Email notifications I guess. But thats a good idea. Will add it.

@xx255q
Copy link
Author

xx255q commented Jul 10, 2020 via email

@Flameish
Copy link
Owner

Make a new issue or send me an email directly. Be advised that the website has to have 10+ novels on it.

@xx255q
Copy link
Author

xx255q commented Jul 10, 2020 via email

@xx255q
Copy link
Author

xx255q commented Jul 22, 2020

I am still having trouble with both downloading and folder creation. There were about a weeks worth of chapters that had come out that did not download until I manually checked a book series, then it seemed the rest updated. Also new chapters are not going into folders, here is what I see:

https://imgur.com/gallery/0rjD1On

As for an example for the paths provided:

Z:\Chinese\Overgeared

@thisvenerableone
Copy link

hiiii, how can i download the program? i've been trying to download but i doesn't work, i don't know what i am doing wrong, can someone explain me?

@Flameish
Copy link
Owner

Flameish commented Sep 15, 2021

I'm not sure how you found this specific issue. (It's about a library feature to bookmark novels). Please read the Readme for instructions or open a new issue if you still have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Add this feature to Novel-Grabber
Projects
None yet
Development

No branches or pull requests

4 participants