Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Announcement per page accept an id list on the params key #4280

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • The UI can receive an id list from the announcement_per_page value.

How did you test this code?

  • In the key params to the value of your feature flag Announcement_per_page, set the value to the IDs of the project, environment, or organisation, where you want the announcement to be displayed.

Now the param values can be a single value or a list of IDs.

This is an example

{ 
"id":"announcement-per-page-3",
"title":"This is a custom announcement for some pages",
"description":"Announcement Page 1",
"buttonText":"Go your page",
"isClosable": true,
"url":"https://app.flagsmith.com/",
"pages":["users","segments","integrations","features"],
"params":{"projectId": [1,2,3], "environmentId":["ABC", "xyz"]}
}

@novakzaballa novakzaballa requested a review from a team as a code owner July 3, 2024 18:18
@novakzaballa novakzaballa requested review from kyle-ssg and removed request for a team July 3, 2024 18:18
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:18pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 3, 2024 6:18pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Uffizzi Preview deployment-53812 was deleted.

@novakzaballa novakzaballa added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit e2685e9 Jul 3, 2024
24 checks passed
@novakzaballa novakzaballa deleted the feat/announcement-per-page-accept-an-id-list-on-the-params-key branch July 3, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants