Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chargebee): ensure multiple addons are counted to subscription limits #2741

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes a bug getting the quantity of addons from the subscription dictionary.

How did you test this code?

Updated unit test.

@matthewelwell matthewelwell requested review from a team and novakzaballa September 5, 2023 14:12
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:18pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:18pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 2:18pm

@github-actions github-actions bot added the api Issue related to the REST API label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Uffizzi Preview deployment-35229 was deleted.

Copy link
Contributor

@dabeeeenster dabeeeenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell merged commit 2ac23a8 into main Sep 5, 2023
13 checks passed
@matthewelwell matthewelwell deleted the fix/chargebee-addons-quantity branch September 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants