Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure feature segments are cloned correctly #2706

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Currently feature segments are generated for the new environment... but not used at all. This PR ensures that feature segments are cloned correctly and used on the resultant feature states.

How did you test this code?

Updated / added unit tests.

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 2:30pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 2:30pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 2:30pm

@github-actions github-actions bot added the api Issue related to the REST API label Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Uffizzi Preview deployment-34766 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b46cc0) 95.47% compared to head (3357ee0) 95.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         986      986           
  Lines       27709    27729   +20     
=======================================
+ Hits        26454    26474   +20     
  Misses       1255     1255           
Files Changed Coverage Δ
api/environments/models.py 95.36% <ø> (-0.05%) ⬇️
api/features/models.py 93.60% <100.00%> (+0.01%) ⬆️
api/tests/integration/conftest.py 100.00% <100.00%> (ø)
...integration/environments/test_clone_environment.py 100.00% <100.00%> (ø)
...i/tests/unit/features/test_unit_features_models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell requested review from a team and khvn26 August 30, 2023 13:46
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with optional comments

api/features/models.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants