Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue retrieving project with master api key #2623

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes issue retrieving project using a Master API Key

How did you test this code?

Added parameterisation to unit tests.

@matthewelwell matthewelwell requested review from a team and novakzaballa August 10, 2023 10:19
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 10:21am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 10:21am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Aug 10, 2023 10:21am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Uffizzi Preview deployment-33124 was deleted.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (863c863) 95.44% compared to head (02e5aa5) 95.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2623   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         976      976           
  Lines       27316    27319    +3     
=======================================
+ Hits        26071    26074    +3     
  Misses       1245     1245           
Files Changed Coverage Δ
api/projects/views.py 94.30% <100.00%> (+0.09%) ⬆️
...pi/tests/unit/projects/test_unit_projects_views.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 1514bf7 into main Aug 10, 2023
13 checks passed
@matthewelwell matthewelwell deleted the fix/project-retrieve-with-master-api-key branch August 10, 2023 10:33
matthewelwell added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants