Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add limits and totals to API responses #2615

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Add feature, segment and segment override limits to API responses.

How did you test this code?

Tests written by Novak as part of #2526.

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 9, 2023 5:15pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:15pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:15pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Uffizzi Preview deployment-33056 was deleted.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 97.56% and no project coverage change.

Comparison is base (cb42f9d) 95.43% compared to head (4b56b22) 95.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2615   +/-   ##
=======================================
  Coverage   95.43%   95.44%           
=======================================
  Files         975      976    +1     
  Lines       27245    27309   +64     
=======================================
+ Hits        26002    26064   +62     
- Misses       1243     1245    +2     
Files Changed Coverage Δ
api/environments/views.py 89.43% <71.42%> (-1.17%) ⬇️
api/audit/serializers.py 100.00% <100.00%> (ø)
api/environments/serializers.py 97.14% <100.00%> (+0.21%) ⬆️
api/organisations/views.py 91.16% <100.00%> (ø)
api/projects/serializers.py 100.00% <100.00%> (ø)
api/projects/tests/test_serializers.py 100.00% <100.00%> (ø)
api/projects/views.py 94.21% <100.00%> (+0.19%) ⬆️
...pi/tests/unit/projects/test_unit_projects_views.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa self-requested a review August 9, 2023 20:40
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@matthewelwell matthewelwell merged commit 321d435 into main Aug 10, 2023
13 checks passed
@matthewelwell matthewelwell deleted the feat/return-limits-and-totals branch August 10, 2023 06:58
matthewelwell added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants