fix: total api calls handling

[kyle-ssg]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Current problems

• The promise to retrieve organisation usage was incorrect, this is causing the following error in production.

Currently in production the total api call detection does not work, this is because we are incorrectly parsing the response.

• The action to get organisation usage is in the render function, this should never happen, side affects (especially API and set state calls) should never be there. This is causing the getOrganisation usage to be rapidly called in production. Luckily Redux RTK detects duplicate api call requests and only hits it once.
• The check to call get organisation usage included whether the total api calls state was 0, the problem with this is that it is infinitely called for new organisations and projects. The only reason why this is not breaking production is because of the first bullet point (It does call around 10 or so times but eventually fails and stops doing it).

Changes

• Fix the promise of getOrganisationUsage to return just the data of the API call
• Only call the organisation usage endpoint when we don't have the data for the active organisation (on mount, on organisation switch)

How did you test this code?

Tested retrieving the initial usage and then switching organisations.

[github-actions]

Uffizzi Preview deployment-32636 was deleted.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 2:41pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 2:41pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 2:41pm

[matthewelwell]

@kyle-ssg is this separate to the graph in the organisation settings then because that seems to be working?

[kyle-ssg]

It is separate yes, this is for API usage warnings. Can see it erroring

However I think there's a more elegant way of managing this so will mark the PR as draft and adjust later today.