Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SwaggerGenerationError): Remove filterset_field #2539

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jul 28, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Because we have the same field(is_system_event) as part of filterset_fields and query_serializer swagger fails with: your query_serializer contains fields that conflict with the filter_backend or paginator_class on the view

The fix is to remove filterset_fields because it is redundant.

How did you test this code?

By loading the documentation while being logged into the admin panel

Because we have the same field(`is_system_event`) as part of
filterset_fields and query_serializer swagger fails
with `your query_serializer contains fields that conflict with the
filter_backend or paginator_class on the view`

The fix is to remove filterset_fields because it is redundant.
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 28, 2023 8:25am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Jul 28, 2023 8:25am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 8:25am

@github-actions github-actions bot added the api Issue related to the REST API label Jul 28, 2023
@gagantrivedi gagantrivedi requested review from a team and novakzaballa July 28, 2023 08:25
@gagantrivedi gagantrivedi marked this pull request as ready for review July 28, 2023 08:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

Uffizzi Preview deployment-32021 was deleted.

@gagantrivedi gagantrivedi merged commit 6dba7bd into main Jul 28, 2023
20 of 22 checks passed
@gagantrivedi gagantrivedi deleted the fix/swagger-docs branch July 28, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants