Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure recurring tasks are unlocked after being picked up (but not executed) #2508

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Ensures that recurring tasks are unlocked after being picked up (but not executed) by the task processor.

How did you test this code?

Updated existing unit test.

@matthewelwell matthewelwell requested review from a team and khvn26 July 24, 2023 13:25
@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 3:36pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 3:36pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 3:36pm

@github-actions github-actions bot added the api Issue related to the REST API label Jul 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Uffizzi Preview deployment-31641 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: -0.01 ⚠️

Comparison is base (583e248) 95.43% compared to head (3cbbf11) 95.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
- Coverage   95.43%   95.43%   -0.01%     
==========================================
  Files         963      963              
  Lines       27061    27078      +17     
==========================================
+ Hits        25827    25843      +16     
- Misses       1234     1235       +1     
Impacted Files Coverage Δ
...sk_processor/test_unit_task_processor_processor.py 98.39% <95.23%> (-0.44%) ⬇️
api/task_processor/models.py 92.30% <100.00%> (+0.15%) ⬆️
api/task_processor/processor.py 93.10% <100.00%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewelwell matthewelwell merged commit 24c21ea into main Jul 24, 2023
12 of 13 checks passed
@matthewelwell matthewelwell deleted the fix/recurring-tasks-second-iteration branch July 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants