Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust AWS payment settings #2400

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 7, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

For AWS subscribers:

  • Don't show any chargebee related items.
  • Lock the seat limit to the number in the subscription (i.e. disable autoseats)

How did you test this code?

Please describe.

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 2:32pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 2:32pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 2:32pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Uffizzi Preview deployment-30409 was deleted.

@matthewelwell
Copy link
Contributor

@kyle-ssg is there any reason from your side that this is still draft? Seems finished to me.

@kyle-ssg kyle-ssg marked this pull request as ready for review July 11, 2023 14:27
@kyle-ssg
Copy link
Member Author

Should be good to go

@dabeeeenster dabeeeenster changed the title Adjust AWS payment settings feat: Adjust AWS payment settings Jul 13, 2023
@matthewelwell
Copy link
Contributor

@kyle-ssg I'm not sure how to test this. I've created an organisation in the Uffizzi environment but I'm not seeing anything related to payments in the organisation settings. I guess it's related to the fact that Uffizzi thinks it's a self hosted environment, but even if I enable the payments_enabled in the staging environment (which I assume Uffizzi is using by default), I still don't see anything related to payments.

@dabeeeenster dabeeeenster merged commit de4618d into main Jul 14, 2023
@dabeeeenster dabeeeenster deleted the chores/adjust_aws_payment_settings branch July 14, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow AWS marketplace customers to modify their subscription via Chargebee
3 participants