Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS review: Need some edits for README examples to work correctly #68

Closed
kanishkan91 opened this issue Apr 5, 2024 · 0 comments
Closed

JOSS review: Need some edits for README examples to work correctly #68

kanishkan91 opened this issue Apr 5, 2024 · 0 comments

Comments

@kanishkan91
Copy link

I think two lines need to be added for the plots in the README to actually show.

First, you would need this at the imports
import matplotlib.pyplot as plt

Secondly, you would need this line at the very end for plots to actually show-
plt.show()

Otherwise you only get an axes object that never actually plots.

openjournals/joss-reviews#6305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kanishkan91