Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the sample out in RFS #9

Open
cnnAndBn opened this issue Oct 27, 2020 · 2 comments
Open

Question about the sample out in RFS #9

cnnAndBn opened this issue Oct 27, 2020 · 2 comments

Comments

@cnnAndBn
Copy link

cnnAndBn commented Oct 27, 2020

hi,
I have a question about the implementation detail in RFS , in the class DistributedGroupSampler_addrepeat_sampleout
defined in sampler.py file, there is a hard coding self.num_to_sample_out= [6000, 17000] , I read the code , it seems that you randomly exclude some images which need not to repeat resampling more than once and the exclusion number are 6000 and 17000 respectively for different group flag
image

if it is ,can you explain the reason why it is needed to do this exlusion and how to decide the exclusion number? thanks a lot

@FishYuLi
Copy link
Owner

@dadada101 Sorry for the confusion.
Actually, DistributedGroupSampler_addrepeat_sampleout is not our implementation for RFS. It's just one of our tryings that does not work. (We should have deleted this class in sample.py)
For our implementation of RFS, please refer to DistributedGroupSampler_addrepeat .

@cnnAndBn
Copy link
Author

ok ,thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants